Repository navigation
Conversation
scripts/ci/{osx,linux64,msys2}/run_tests.sh have set -e commented out,
so a failed make didn't fail the job. On osx the emptyExample and
allAddonsExample builds weren't checked at all: allAddonsExample has been
failing to link on master (undefined kleidicv:: symbols from the macOS
OpenCV package) while build-macos (osx, makefiles) stayed green. On linux64
and msys2 a failed test build only showed up later as a missing binary.
Each make now goes through build_or_fail, which stops the job and adds a
GitHub error annotation naming the build. The tests' own exit code checks
are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build-macos (osx, makefiles)is green on master, butallAddonsExamplefails to link in it. From master's run on 13 Oct:The projectGenerator CI builds the same project with Xcode and fails, which is how this showed up.
scripts/ci/osx/run_tests.sh,linux64/run_tests.shandmsys2/run_tests.shall haveset -ecommented out (since #7947):emptyExampleandallAddonsExamplebuilds aren't checked at all.Change
Each
makein those scripts goes throughbuild_or_fail. If a build fails, it stops the job with a GitHub error annotation naming it:The tests' own exit-code checks are unchanged.
Expected result
build-macos (osx, makefiles)will fail on this PR until the macOS OpenCV package is fixed in apothecary. Itsopencv.auses KleidiCV, butlibkleidicvisn't in the xcframework. The fix is to build it with-DWITH_KLEIDICV=OFF, or to shiplibkleidicv. That failure is the point: it has been hidden until now.